Re: [rdiff-backup-users] "--compare-hash-at-time" bug?

[Serge Zub]

Hi,

The version 1.3.1 still has the problem.
I've looked into the source and it seems I've found the cause!

File "hash.py":

def compute_sha1(rp, compressed = 0):
    """Return the hex sha1 hash of given rpath"""
    assert rp.conn is Globals.local_connection # inefficient not to do locally
    digest = compute_sha1_fp(rp.open("r", compressed))
    rp.set_sha1(digest)
    return digest

"r"  -- file is opened in text mode.
I suppose that it must be "rb".

Thanks.

On Fri, Feb 27, 2009 at 3:08 PM, Serge Zub <address@hidden> wrote:

It is still reproduced with the "--no-hard-links" option explicitly added to the backup and compare commands.

rdiff-backup-1.3.1.exe --no-hard-links dos backup
rdiff-backup-1.3.1.exe --no-hard-links --compare-hash-at-time 0B dos backup

It seems to me that this method resolves the problem you refer.

On Fri, Feb 27, 2009 at 7:22 AM, Ryan <address@hidden> wrote:

it's a bug, see:

http://lists.gnu.org/archive/html/rdiff-backup-users/2009-01/msg00219.html

_______________________________________________
rdiff-backup-users mailing list at address@hidden
http://lists.nongnu.org/mailman/listinfo/rdiff-backup-users
Wiki URL: http://rdiff-backup.solutionsfirst.com.au/index.php/RdiffBackupWiki