Re: [rdiff-backup-users] Re: Combining --max-file-size and --exclude bug?

[Patrick Nagel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

On 2009-01-31 06:09, Andrew Ferguson wrote:
[...]
> Fortunately, the fix is simple. In selection.py just change lines 534
> and 535:
> 
>         if min_max: sel_func = lambda rp: (rp.getsize() <= size)
>         else: sel_func = lambda rp: (rp.getsize() >= size)
> 
> to
> 
>         if min_max: sel_func = lambda rp: (rp.getsize() <= size) and None
>         else: sel_func = lambda rp: (rp.getsize() >= size) and None
> 
> (that is, put "and None" at the end)
> 
> 
> I think I will put this change in the 1.3.x branch ... do people think
> this should be a new option? or should we just change the semantics of
> --max-file-size / --min-file-size ? (I'm leaning towards the latter ...)

I'd prefer the latter. Probably nobody ever wants the current behaviour, and
thus it would not make sense to offer this as configuration option.

> While we're talking about this, I noticed that this function doesn't do
> any special handling for directories... anyone care to comment? I think
> it would be strange to have rdiff-backup exclude a directory because it
> had too many or too few files when using these options.

Indeed, that would be strange. Directories themselves should not be affected
by the --[min|max]-file-size option at all, imo.

Patrick.

- --
Key ID: 0x86E346D4            http://patrick-nagel.net/key.asc
Fingerprint: 7745 E1BE FA8B FBAD 76AB 2BFC C981 E686 86E3 46D4
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmEKwoACgkQyYHmhobjRtQn3ACcCs28nAMd8Q+e+xe/HSCwxfWg
yMMAoJQv4PfafevYoxiwUcI1ya4gKWpu
=0eSE
-----END PGP SIGNATURE-----