Re: [rdiff-backup-users] 'inc_compressed' bug

[Andrew Ferguson]

Sebastien Maret wrote:
> Hello,
> 
> I have hit a again the "inc_compressed" bug while regressing my destination 
> directory.

Sebastien,

I believe the fix Dean Gaudet gave you is correct, but that something
else is going on for your second error. See below:

> I am not getting an other error:
> 
> % rdiff-backup --force --check-destination-dir MacBook
> Exception '[Errno 2] No such file or directory: 
> 'MacBook/rdiff-backup-data/mirror_metadata.2007-01-04T13:00:07-05:00.snapshot.gz''
>  raised of class 'exceptions.OSError':
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 295, in 
> error_check_Main
>     try: Main(arglist)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 315, in 
> Main
>     take_action(rps)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 273, in 
> take_action
>     elif action == "check-destination-dir": CheckDest(rps[0])
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 781, in 
> CheckDest
>     dest_rp.conn.regress.Regress(dest_rp)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 69, in 
> Regress
>     regress_rbdir(manager)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 124, 
> in regress_rbdir
>     if has_meta_diff and not has_meta_snap: recreate_meta(meta_manager)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 153, 
> in recreate_meta
>     rpath.rename(temprp, finalrp)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/rpath.py", line 230, in 
> rename
>     if not rp_source.lstat(): rp_dest.delete()
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/rpath.py", line 946, in 
> delete
>     else: self.conn.os.unlink(self.path)


If we look at what is going on, rdiff-backup is trying to rename a temp
file to a finalrp with the name
'MacBook/rdiff-backup-data/mirror_metadata.2007-01-04T13:00:07-05:00.snapshot.gz'

However, the rename operation is trying to delete that finalrp because
it believes the tempfile does not exist!

Can you reproduce this bug again, but this time with verbosity 7 or 8? I
would very much like to see the output. In particular, before the error
you should have a line like:

Renaming MacBook/rdiff-backup-data/rdiff-backup.tmp.# to
MacBook/rdiff-backup-data/mirror_metadata.2007-01-04T13:00:07-05:00.snapshot.gz

After it fails, can you see if that first file even exists? (It should
... it should be the file created in regress.py on lines 144-148, right
before regress.py line 153.) If it doesn't exist, than something is
going wrong with recreating the metadata snapshot.

Are there any more details you can provide if you can't reproduce this
case? Eg, why were you regressing? From what date? To what date?

Thanks,
Andrew

-- 
Andrew Ferguson - address@hidden