[rdiff-backup-users] rdiff-backup + smbfs = :'(

[Peter Valdemar Mørch]

Hi there,

I'm trying to rdiff-backup from linux to a smbfs mount.

That ends up giving me an error: "Exception '[Errno 16] Device or 
resource busy removing 
/mnt/backup/BackupCapMon/cmdev-rdiff-backup/rdiff-backup-data/rdiff-backup.tmp.0' 
raised of class 'exceptions.OSError':"
(complete error here:
http://demo.capmon.dk/~pvm/rdiff-backup/smb-fsync-error.txt
)

A similar thread was found in:
http://lists.gnu.org/archive/html/rdiff-backup-users/2004-10/msg00043.html
and the wiki has: 
http://rdiff-backup.solutionsfirst.com.au/index.php/FsyncErrorError

In there, a patch is suggested. However neither context nor version was 
specified, so I introduce a cvs diff -u against CVS HEAD.

Being new to rdiff-backup, what are the odds of this patch making it 
into HEAD?

Peter

> cvs diff -u
cvs diff: Diffing .
Index: rpath.py
===================================================================
RCS file: /sources/rdiff-backup/rdiff-backup/rdiff_backup/rpath.py,v
retrieving revision 1.99
diff -u -r1.99 rpath.py
--- rpath.py    13 Jan 2006 05:29:47 -0000      1.99
+++ rpath.py    28 Jun 2006 15:34:48 -0000
@@ -1145,7 +1145,11 @@
                assert self.conn is Globals.local_connection
                try:
                        fd = os.open(self.path, os.O_RDONLY)
-                       os.fsync(fd)
+                       try:
+                               os.fsync(fd)
+                       except:
+                               os.close(fd)
+                               raise
                        os.close(fd)
                except OSError, e:
                        if locals().has_key('fd'): os.close(fd)

--
Peter Valdemar Mørch
http://www.morch.com