|
From: | Peter Williams |
Subject: | Re: [Quilt-dev] [PATCH] Enhanced decoration for "series -v" command |
Date: | Wed, 15 Jun 2005 12:45:42 +1000 |
User-agent: | Mozilla Thunderbird 1.0.2-1.3.2 (X11/20050324) |
Peter Williams wrote:
Andreas Gruenbacher wrote:The reason why your version of files_may_have_changed is still not exact is that all files that a pop restores get the current timestamp to play nice with tools like make, so after that, files_may_have_changed will start to give false positives. An exact version of files_may_have_changed would have to keep track of the timestamps of all files that any patch modifies.Yes. It looks like a "diff --brief" may be necessary as a last resort.BTW If we can get files_may_have_changed() working properly then parts of "pop" may (possibly) be simplified which may regain some of the lost efficiency.
I've been looking at a method to tell whether just one file in a patch needs refreshing (to use as the last check in files_may_have_changed) and would like to use one of the commands (filterdiff) from patchutils
<http://freshmeat.net/projects/patchutils/>to extract the patch for the file in question from the patch file so that it can be used to modify a copy of the file for comparison with the next version of the file above it in the series. This would have the consequence of making quilt dependent on patchutils. Would this be acceptable?
Peter -- Peter Williams address@hidden "Learning, n. The kind of ignorance distinguishing the studious." -- Ambrose Bierce
[Prev in Thread] | Current Thread | [Next in Thread] |