[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [PATCH] fix diffstat garbage output
From: |
Jean Delvare |
Subject: |
Re: [Quilt-dev] [PATCH] fix diffstat garbage output |
Date: |
Tue, 24 May 2005 21:46:43 +0200 |
[Jean Delvare]
> Good catch, my test was broken. However yours isn't perfect either,
> for example it would fail to warn on version 0.35. Although such a
> version probably never existed, I'd prefer the test to be accurate so
> that future changes (when quilt starts requiring even newer versions
> of diffstat) won't break. Wouldn't the proper test be:
> major -lt 1 -o \( major -eq 1 -a minor -lt 32 \)
> ?
Here comes an updated version of the patch, fixing the test bug Martin
spotted, and against quilt CVS this time.
Thanks,
--
Jean Delvare
quilt-CVS-configure-diffstat-version-3.diff
Description: Text document