Re: [Quilt-dev] [PATCH] fix diffstat garbage output

[Jean Delvare]

[Martin Quinson]
> From what I see, you will warn on version 2.01 too. I'd change the 
>   test  major -lt 1 -o minor -lt 32
> to
>   test  major -le 1 -a minor -lt 32
> or so.

Good catch, my test was broken. However yours isn't perfect either, for
example it would fail to warn on version 0.35. Although such a version
probably never existed, I'd prefer the test to be accurate so that
future changes (when quilt starts requiring even newer versions of
diffstat) won't break. Wouldn't the proper test be:
   major -lt 1 -o \( major -eq 1 -a minor -lt 32 \)
?

[Martin Quinson]
> I've 1.39 in debian (testing), but I'm sure the version in stable is
> *ancient*.

You're right, stable has 1.28. That being said, stable doesn't have
quilt, so it doesn't really matter in this case.

Thanks,
--
Jean Delvare