|
From: | Alex Bennée |
Subject: | Re: [PATCH v3 3/7] accel/tcg/user-exec: silence the compiler warnings |
Date: | Mon, 16 Nov 2020 13:36:16 +0000 |
User-agent: | mu4e 1.5.7; emacs 28.0.50 |
Chen Qun <kuhn.chenqun@huawei.com> writes: > When using -Wimplicit-fallthrough in our CFLAGS on GCC9, the compiler showed > warning: > ../accel/tcg/user-exec.c: In function ‘handle_cpu_signal’: > ../accel/tcg/user-exec.c:169:13: warning: this statement may fall through > [-Wimplicit-fallthrough=] > 169 | cpu_exit_tb_from_sighandler(cpu, old_set); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../accel/tcg/user-exec.c:172:9: note: here > 172 | default: > > Mark the cpu_exit_tb_from_sighandler() function with QEMU_NORETURN to fix it. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> -- Alex Bennée
[Prev in Thread] | Current Thread | [Next in Thread] |