[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 7/7] target/ppc: replaced the TODO with LOG_UNIMP and add brea
From: |
Chen Qun |
Subject: |
[PATCH v3 7/7] target/ppc: replaced the TODO with LOG_UNIMP and add break for silence warnings |
Date: |
Mon, 16 Nov 2020 10:48:10 +0800 |
When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
target/ppc/mmu_helper.c: In function ‘dump_mmu’:
target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through
[-Wimplicit-fallthrough=]
1351 | if (ppc64_v3_radix(env_archcpu(env))) {
| ^
target/ppc/mmu_helper.c:1358:5: note: here
1358 | default:
| ^~~~~~~
Use "qemu_log_mask(LOG_UNIMP**)" instead of the TODO comment.
And add the break statement to fix it.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
---
v1->v2: replace the TODO by a LOG_UNIMP call and add break statement(Base on
Philippe's comments)
Cc: Thomas Huth <thuth@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
---
target/ppc/mmu_helper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c
index 8972714775..3bb50546f8 100644
--- a/target/ppc/mmu_helper.c
+++ b/target/ppc/mmu_helper.c
@@ -1349,11 +1349,12 @@ void dump_mmu(CPUPPCState *env)
break;
case POWERPC_MMU_3_00:
if (ppc64_v3_radix(env_archcpu(env))) {
- /* TODO - Unsupported */
+ qemu_log_mask(LOG_UNIMP, "%s: the PPC64 MMU is unsupported\n",
+ __func__);
} else {
dump_slb(env_archcpu(env));
- break;
}
+ break;
#endif
default:
qemu_log_mask(LOG_UNIMP, "%s: unimplemented\n", __func__);
--
2.27.0
- [PATCH v3 0/7] silence the compiler warnings, Chen Qun, 2020/11/15
- [PATCH v3 1/7] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Chen Qun, 2020/11/15
- [PATCH v3 3/7] accel/tcg/user-exec: silence the compiler warnings, Chen Qun, 2020/11/15
- [PATCH v3 6/7] ppc: Add a missing break for PPC6xx_INPUT_TBEN, Chen Qun, 2020/11/15
- [PATCH v3 4/7] target/sparc/translate: silence the compiler warnings, Chen Qun, 2020/11/15
- [PATCH v3 7/7] target/ppc: replaced the TODO with LOG_UNIMP and add break for silence warnings,
Chen Qun <=
- [PATCH v3 5/7] target/sparc/win_helper: silence the compiler warnings, Chen Qun, 2020/11/15
- [PATCH v3 2/7] hw/intc/arm_gicv3_kvm: silence the compiler warnings, Chen Qun, 2020/11/15