[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH] hw/audio/intel-hda: Avoid shift into sign bit
From: |
Peter Maydell |
Subject: |
[Qemu-trivial] [PATCH] hw/audio/intel-hda: Avoid shift into sign bit |
Date: |
Fri, 9 May 2014 14:22:53 +0100 |
Add a U suffix to avoid shifting into the sign bit (which is
undefined behaviour in C).
Signed-off-by: Peter Maydell <address@hidden>
---
Another one from clang's sanitizer...
hw/audio/intel-hda.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
index d41f82c..0cec2d2 100644
--- a/hw/audio/intel-hda.c
+++ b/hw/audio/intel-hda.c
@@ -245,7 +245,7 @@ static void intel_hda_update_int_sts(IntelHDAState *d)
/* update global status */
if (sts & d->int_ctl) {
- sts |= (1 << 31);
+ sts |= (1U << 31);
}
d->int_sts = sts;
@@ -257,7 +257,7 @@ static void intel_hda_update_irq(IntelHDAState *d)
int level;
intel_hda_update_int_sts(d);
- if (d->int_sts & (1 << 31) && d->int_ctl & (1 << 31)) {
+ if (d->int_sts & (1U << 31) && d->int_ctl & (1U << 31)) {
level = 1;
} else {
level = 0;
--
1.9.2
- [Qemu-trivial] [PATCH] hw/audio/intel-hda: Avoid shift into sign bit,
Peter Maydell <=