[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2] serial-pci: Set prog interface field of pc
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-trivial] [PATCH v2] serial-pci: Set prog interface field of pci config to 16550 compatible |
Date: |
Thu, 08 May 2014 21:55:25 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 |
27.02.2014 05:05, BALATON Zoltan wrote:
Shoudl we actually make it machine-specific, to keep even prog-if value
of these things the same as before for older machine types? I dunno.
mst says we should, I think this is not a very important property to keep.
Thanks,
/mjt
> v2: resubmission after pc-2.1 is added with the multiport case
>
> hw/char/serial-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c
> index 991c99f..f3f5e07 100644
> --- a/hw/char/serial-pci.c
> +++ b/hw/char/serial-pci.c
> @@ -60,6 +60,7 @@ static int serial_pci_init(PCIDevice *dev)
> return -1;
> }
>
> + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
> pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;
> s->irq = pci_allocate_irq(&pci->dev);
>
> @@ -101,6 +102,7 @@ static int multi_serial_pci_init(PCIDevice *dev)
> assert(pci->ports > 0);
> assert(pci->ports <= PCI_SERIAL_MAX_PORTS);
>
> + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
> pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;
> memory_region_init(&pci->iobar, OBJECT(pci), "multiserial", 8 *
> pci->ports);
> pci_register_bar(&pci->dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &pci->iobar);
>