Re: [PATCH 1/6] tests/9p: add 'use-after-unlink' test

[Christian Schoenebeck]

On Monday, November 25, 2024 9:47:17 AM CET Greg Kurz wrote:
> Hi Christian,
> 
> On Wed, 21 Feb 2024 15:13:13 +0100
> Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> 
> > After removing a file from the file system, we should still be able to
> > work with the file if we already had it open before removal.
> > 
> > As a first step we verify that it is possible to write to an unlinked
> > file, as this is what already works. This test is extended later on
> > after having fixed other use cases after unlink that are not working
> > yet.
> > 
> > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > ---
> 
> Test looks good but make sure it is merged last to preserve bisect.

I think there is a misapprehension: this test already passed! So no need to
move this patch.

What this test does is verifying the scenario open-unlink-write. I already
sent this patch in February and was surprised by myself that this idiom
already works:

https://lore.kernel.org/all/E1rcnYJ-0004KK-LV@lizzy.crudebyte.com/

What this entire series (i.e. patch 5) rather fixes is the idiom
open-unlink-fstat, and the test for this idiom is the last patch, not this
first one here.

So bisect is already fine.

> Reviewed-by: Greg Kurz <groug@kaod.org>

Thanks!

/Christian