Re: [PATCH 4/6] 9pfs: remove obsolete comment in v9fs_getattr()

[Greg Kurz]

On Sun, 24 Nov 2024 16:06:40 +0100
Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:

> The comment claims that we'd only support basic Tgetattr fields. This is
> no longer true, so remove this comment.
> 
> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> ---

Heh another very long standing nit :-)

Good catch !

Reviewed-by: Greg Kurz <groug@kaod.org>

>  hw/9pfs/9p.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index 9a291d1b51..851e36b9a1 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -1596,10 +1596,6 @@ static void coroutine_fn v9fs_getattr(void *opaque)
>          retval = -ENOENT;
>          goto out_nofid;
>      }
> -    /*
> -     * Currently we only support BASIC fields in stat, so there is no
> -     * need to look at request_mask.
> -     */
>      retval = v9fs_co_lstat(pdu, &fidp->path, &stbuf);
>      if (retval < 0) {
>          goto out;



-- 
Greg