Re: [PATCH v2] hw/nvme: fix handling of over-committed queues

[Waldek Kozaczuk]

I have run my tests on the OSv side with small queue sizes like 3,4,5 and I could NOT replicate the issue. So it looks like the V2 version of this patch fixes the problem.

Thanks a lot,

Waldemar Kozaczuk

On Mon, Nov 4, 2024 at 1:57 PM Keith Busch <kbusch@kernel.org> wrote:

On Tue, Oct 29, 2024 at 01:15:19PM +0100, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> If a host chooses to use the SQHD "hint" in the CQE to know if there is
> room in the submission queue for additional commands, it may result in a
> situation where there are not enough internal resources (struct
> NvmeRequest) available to process the command. For a lack of a better
> term, the host may "over-commit" the device (i.e., it may have more
> inflight commands than the queue size).
>
> ...

LGTM

Reviewed-by: Keith Busch <kbusch@kernel.org>