[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] hw/nvme: fix handling of over-committed queues
|
From: |
Keith Busch |
|
Subject: |
Re: [PATCH v2] hw/nvme: fix handling of over-committed queues |
|
Date: |
Mon, 4 Nov 2024 11:57:34 -0700 |
On Tue, Oct 29, 2024 at 01:15:19PM +0100, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> If a host chooses to use the SQHD "hint" in the CQE to know if there is
> room in the submission queue for additional commands, it may result in a
> situation where there are not enough internal resources (struct
> NvmeRequest) available to process the command. For a lack of a better
> term, the host may "over-commit" the device (i.e., it may have more
> inflight commands than the queue size).
>
> ...
LGTM
Reviewed-by: Keith Busch <kbusch@kernel.org>