Re: [PATCH v2 2/2] net: move backend cleanup to NIC cleanup

[Jason Wang]

On Wed, Sep 18, 2024 at 11:57 AM Si-Wei Liu <si-wei.liu@oracle.com> wrote:
>
>
>
> On 9/12/2024 9:54 AM, Eugenio Pérez wrote:
> > Commit a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net
> > structures if peer nic is present") effectively delayed the backend
> > cleanup, allowing the frontend or the guest to access it resources as
> > long as the frontend is still visible to the guest.
> >
> > However it does not clean up the resources until the qemu process is
> > over.  This causes an effective leak if the device is deleted with
> > device_del, as there is no way to close the vdpa device.  This makes
> > impossible to re-add that device to this or other QEMU instances until
> > the first instance of QEMU is finished.
> >
> > Move the cleanup from qemu_cleanup to the NIC deletion and to
> > net_cleanup.
> >
> > Fixes: a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net 
> > structures if peer nic is present")
> > Reported-by: Lei Yang <leiyang@redhat.com>
> > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>

Queued.

Thanks