[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-block] [PATCH 7/7] curl: do not do aio_poll when
From: |
Max Reitz |
Subject: |
Re: [Qemu-stable] [Qemu-block] [PATCH 7/7] curl: do not do aio_poll when waiting for a free CURLState |
Date: |
Wed, 10 May 2017 19:54:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 10.05.2017 16:32, Paolo Bonzini wrote:
> Instead, put the CURLAIOCB on a wait list; curl_clean_state will
> wake the corresponding coroutine.
>
> Because of CURL's callback-based structure, we cannot easily convert
> everything to CoMutex/CoQueue; keeping the QemuMutex is simpler.
> However, CoQueue is a simple wrapper around a linked list, so we can
> use QSIMPLEQ easily to open-code a CoQueue that has a QemuMutex's
> protection instead of a CoMutex's.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block/curl.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-stable] [PATCH 2/7] curl: never invoke callbacks with s->mutex held, (continued)
- [Qemu-stable] [PATCH 4/7] curl: split curl_find_state/curl_init_state, Paolo Bonzini, 2017/05/10
- [Qemu-stable] [PATCH 3/7] curl: avoid recursive locking of BDRVCURLState mutex, Paolo Bonzini, 2017/05/10
- [Qemu-stable] [PATCH 7/7] curl: do not do aio_poll when waiting for a free CURLState, Paolo Bonzini, 2017/05/10
- [Qemu-stable] [PATCH 5/7] curl: convert CURLAIOCB to byte values, Paolo Bonzini, 2017/05/10
- [Qemu-stable] [PATCH 6/7] curl: convert readv to coroutines, Paolo Bonzini, 2017/05/10
- Re: [Qemu-stable] [Qemu-devel] [PATCH v2 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll, no-reply, 2017/05/10
- Re: [Qemu-stable] [PATCH v2 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll, Richard W.M. Jones, 2017/05/10