[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v3 07/19] block: expect errors from bdrv_co_is_
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-stable] [PATCH v3 07/19] block: expect errors from bdrv_co_is_allocated |
|
Date: |
Mon, 29 Jul 2013 16:03:47 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
Il 29/07/2013 15:43, Kevin Wolf ha scritto:
> Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben:
>> Some bdrv_is_allocated callers do not expect errors, but the fallback
>> in qcow2.c might make other callers trip on assertion failures or
>> infinite loops.
>>
>> Fix the callers to always look for errors.
>>
>> Cc: address@hidden
>> Reviewed-by: Eric Blake <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>
> Good idea, but there seem to be a few more callers that don't handle
> errors yet. Not sure what your criterion for fixing callers or not was.
> Did you simply miss the rest?
In general, I didn't bother about callers that didn't handle *pnum = 0
correctly (for example block-migration.c and commit). But I see now
that the ones in qemu-io-cmds.c are due to a bad rebase.
(BTW, I just noticed now that both block-migration.c and commit also run
outside a coroutine, and thus rely on bdrv_is_allocated creating one).
Paolo