[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v3 07/19] block: expect errors from bdrv_co_is_
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-stable] [PATCH v3 07/19] block: expect errors from bdrv_co_is_allocated |
|
Date: |
Mon, 29 Jul 2013 15:43:49 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben:
> Some bdrv_is_allocated callers do not expect errors, but the fallback
> in qcow2.c might make other callers trip on assertion failures or
> infinite loops.
>
> Fix the callers to always look for errors.
>
> Cc: address@hidden
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
Good idea, but there seem to be a few more callers that don't handle
errors yet. Not sure what your criterion for fixing callers or not was.
Did you simply miss the rest?
Kevin