[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v2] block: fix bdrv_flush() ordering in bdrv_cl
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-stable] [PATCH v2] block: fix bdrv_flush() ordering in bdrv_close() |
|
Date: |
Wed, 3 Jul 2013 10:34:11 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jul 02, 2013 at 03:36:25PM +0200, Stefan Hajnoczi wrote:
> Since 80ccf93b we flush the block device during close. The
> bdrv_drain_all() call should come before bdrv_flush() to ensure guest
> write requests have completed. Otherwise we may miss pending writes
> when flushing.
>
> Call bdrv_drain_all() again for safety as the final step after
> bdrv_flush(). This should not be necessary but we can be paranoid here
> in case bdrv_flush() left I/O pending.
>
> Cc: address@hidden
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> v2:
> * Drain after block_job_cancel_sync() [kwolf]
>
> block.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan