Re: [Qemu-stable] [PATCH v2] block: fix bdrv_flush() ordering in bdrv_close()

[Kevin Wolf]

Am 02.07.2013 um 15:36 hat Stefan Hajnoczi geschrieben:
> Since 80ccf93b we flush the block device during close.  The
> bdrv_drain_all() call should come before bdrv_flush() to ensure guest
> write requests have completed.  Otherwise we may miss pending writes
> when flushing.
> 
> Call bdrv_drain_all() again for safety as the final step after
> bdrv_flush().  This should not be necessary but we can be paranoid here
> in case bdrv_flush() left I/O pending.
> 
> Cc: address@hidden
> Signed-off-by: Stefan Hajnoczi <address@hidden>

Reviewed-by: Kevin Wolf <address@hidden>