[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 0/5] target/s390x: CC fixes
From: |
Ilya Leoshkevich |
Subject: |
[PATCH v2 0/5] target/s390x: CC fixes |
Date: |
Mon, 6 Nov 2023 10:31:21 +0100 |
v1: https://lists.gnu.org/archive/html/qemu-devel/2023-10/msg10251.html
v1 -> v2: Introduce op_laa_addu64() (Richard).
Add the ADD LOGICAL WITH CARRY test. This was intended to
catch the issue mentioned by David, but did not succeed. I
thought it would still be worthwile to include it as a
regression test.
Hi,
This series fixes two issues with updating CC. David was suggesting a
bigger rewrite [1], but I did not dare do this (yet). Instead, these
are targeted fixes: patch 1 helps with installing Fedora, and patch 3
addresses something I noticed when reviewing the code. Patches 2, 4 and
5 are tests.
Best regards,
Ilya
[1] https://gitlab.com/qemu-project/qemu/-/issues/1865#note_1545060658
Ilya Leoshkevich (5):
target/s390x: Fix CLC corrupting cc_src
tests/tcg/s390x: Test CLC with inaccessible second operand
target/s390x: Fix LAALG not updating cc_src
tests/tcg/s390x: Test LAALG with negative cc_src
tests/tcg/s390x: Test ADD LOGICAL WITH CARRY
target/s390x/tcg/insn-data.h.inc | 2 +-
target/s390x/tcg/translate.c | 26 +++-
tests/tcg/s390x/Makefile.target | 3 +
tests/tcg/s390x/add-logical-with-carry.c | 156 +++++++++++++++++++++++
tests/tcg/s390x/clc.c | 48 +++++++
tests/tcg/s390x/laalg.c | 27 ++++
6 files changed, 257 insertions(+), 5 deletions(-)
create mode 100644 tests/tcg/s390x/add-logical-with-carry.c
create mode 100644 tests/tcg/s390x/clc.c
create mode 100644 tests/tcg/s390x/laalg.c
--
2.41.0
- [PATCH v2 0/5] target/s390x: CC fixes,
Ilya Leoshkevich <=
- [PATCH v2 4/5] tests/tcg/s390x: Test LAALG with negative cc_src, Ilya Leoshkevich, 2023/11/06
- [PATCH v2 3/5] target/s390x: Fix LAALG not updating cc_src, Ilya Leoshkevich, 2023/11/06
- [PATCH v2 1/5] target/s390x: Fix CLC corrupting cc_src, Ilya Leoshkevich, 2023/11/06
- [PATCH v2 2/5] tests/tcg/s390x: Test CLC with inaccessible second operand, Ilya Leoshkevich, 2023/11/06
- [PATCH v2 5/5] tests/tcg/s390x: Test ADD LOGICAL WITH CARRY, Ilya Leoshkevich, 2023/11/06