Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

[Paolo Bonzini]

On 5/3/23 20:32, Peter Maydell wrote:
> Do we really want to build a QEMU that then barfs unless
> you pass -nodefaults, though ? That doesn't seem very useful.
> Something somewhere ought to be saying "if you want the
> virt board then you almost certainly want these".

Well, the point is that --without-default-devices is intended to be for 
people that write their device config by hand.

However, perhaps we can add to configs/devices/ enough lines that a 
--without-default-devices configuration is moderately useful.  For 
example, some of the changes in this series could be rewritten as:

diff --git a/configs/devices/aarch64-softmmu/default.mak 
b/configs/devices/aarch64-softmmu/default.mak
index cf43ac8da116..3aaca2770590 100644
--- a/configs/devices/aarch64-softmmu/default.mak
+++ b/configs/devices/aarch64-softmmu/default.mak
@@ -3,6 +3,20 @@
 # We support all the 32 bit boards so need all their config
 include ../arm-softmmu/default.mak

+# ------
+# Boards
+# ------
+
 CONFIG_XLNX_ZYNQMP_ARM=y
 CONFIG_XLNX_VERSAL=y
 CONFIG_SBSA_REF=y
+
+# ---------------------------------------------------------------------
+# Sample configuration for a --without-default-devices build.  These
+# devices already default to enabled; they are listed here so that
+# building without default devices 1) still results in a somewhat
+# useful emulator 2) does not fail "make check".
+# ---------------------------------------------------------------------
+
+# For CONFIG_SBSA_REF:
+CONFIG_VIRTIO_NET=y
diff --git a/configs/devices/arm-softmmu/default.mak 
b/configs/devices/arm-softmmu/default.mak
index 1b49a7830c7e..81057d146d1b 100644
--- a/configs/devices/arm-softmmu/default.mak
+++ b/configs/devices/arm-softmmu/default.mak
@@ -3,6 +3,10 @@
 # CONFIG_PCI_DEVICES=n
 # CONFIG_TEST_DEVICES=n

+# ------
+# Boards
+# ------
+
 CONFIG_ARM_VIRT=y
 CONFIG_CUBIEBOARD=y
 CONFIG_EXYNOS4=y
@@ -43,3 +47,13 @@ CONFIG_FSL_IMX6UL=y
 CONFIG_SEMIHOSTING=y
 CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y
 CONFIG_ALLWINNER_H3=y
+
+# ---------------------------------------------------------------------
+# Sample configuration for a --without-default-devices build.  These
+# devices already default to enabled; they are listed here so that
+# building without default devices 1) still results in a somewhat
+# useful emulator 2) does not fail "make check".
+# ---------------------------------------------------------------------
+
+# For CONFIG_ARM_VIRT:
+CONFIG_VIRTIO_NET=y


And then we can progressively work towards removing "2) does not fail 
make check".

Paolo