qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine


From: Paolo Bonzini
Subject: Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine
Date: Wed, 3 May 2023 19:05:59 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1

On 5/3/23 17:35, Alex Bennée wrote:
You should select a device only if you cannot even start
the machine without --nodefaults.

Which is the case here right? We could skip tests that explicitly
instantiate a device but these are tests failing with default devices
the machine tries to instantiate.

I'm sorry, I meant "select" directives are needed if you cannot even start the machine *with* --nodefaults.

Devices that are added *without* --nodefaults should use "imply" directives instead, as is already the case.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]