[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] migration: Remove unused res_compatible
From: |
Juan Quintela |
Subject: |
Re: [PATCH 2/3] migration: Remove unused res_compatible |
Date: |
Tue, 14 Feb 2023 19:14:18 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> On 08.02.23 16:57, Juan Quintela wrote:
>> {
>> - uint64_t pend_pre, pend_compat, pend_post;
>> + uint64_t pend_pre, pend_post;
>> bool in_postcopy = s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE;
>> - qemu_savevm_state_pending_estimate(&pend_pre, &pend_compat,
>> &pend_post);
>> - uint64_t pending_size = pend_pre + pend_compat + pend_post;
>> + qemu_savevm_state_pending_estimate(&pend_pre, &pend_post);
>> + uint64_t pending_size = pend_pre + pend_post;
>
> Mixed declarations are "gnerally not allowed" by devel/style.rst..
> Preexisting, but we may fix it now.
They are used left and right.
But you are right. Instead to change my code, I have sent a proposal to
change devel/style.rst.
Discuss it there O:-)
> Anyway:
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Thanks.
[PATCH 2/3] migration: Remove unused res_compatible, Juan Quintela, 2023/02/08
[PATCH 3/3] migration: Remove _only suffix for res_postcopy/precopy, Juan Quintela, 2023/02/08