[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] migration: In case of postcopy, the memory ends in res_p
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH 1/3] migration: In case of postcopy, the memory ends in res_postcopy_only |
|
Date: |
Tue, 14 Feb 2023 16:47:16 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> On 09.02.23 21:10, Juan Quintela wrote:
>> Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
>>> On 08.02.23 16:57, Juan Quintela wrote:
>>>> So remove last assignation of res_compatible.
>>
>
>
> I think, that the order of logic and documentation changing since introducing
> _estimate is a bit confused.
>
> But I agree now, that we are safe to unite old compat and old postcopy_only
> into one variable, as we want only
>
> 1. the total sum, to probably go to migration_completion()
> 2. pend_pre to probably go to postcopy_start()
>
> So, patch is OK, and seems it changes absolutely nothing in logic. Thanks for
> explanations!
>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Thanks.
You are welcome.
[PATCH 2/3] migration: Remove unused res_compatible, Juan Quintela, 2023/02/08
[PATCH 3/3] migration: Remove _only suffix for res_postcopy/precopy, Juan Quintela, 2023/02/08