Re: [PATCH v4 6/8] Update lcitool and fedora to 37

[Alex Bennée]

marcandre.lureau@redhat.com writes:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Fedora 35 is EOL.
>
> Update to upstream lcitool, that dropped f35 and added f37.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/docker/dockerfiles/fedora-win32-cross.docker | 4 ++--
>  tests/docker/dockerfiles/fedora-win64-cross.docker | 4 ++--
>  tests/docker/dockerfiles/fedora.docker             | 4 ++--
>  tests/lcitool/libvirt-ci                           | 2 +-
>  tests/lcitool/refresh                              | 6 +++---
>  5 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/fedora-win32-cross.docker 
> b/tests/docker/dockerfiles/fedora-win32-cross.docker
> index 75383ba185..cc5d1ac4be 100644
> --- a/tests/docker/dockerfiles/fedora-win32-cross.docker
> +++ b/tests/docker/dockerfiles/fedora-win32-cross.docker
> @@ -1,10 +1,10 @@
>  # THIS FILE WAS AUTO-GENERATED
>  #
> -#  $ lcitool dockerfile --layers all --cross mingw32 fedora-35 qemu
> +#  $ lcitool dockerfile --layers all --cross mingw32 fedora-37 qemu
>  #
>  # https://gitlab.com/libvirt/libvirt-ci
>  
> -FROM registry.fedoraproject.org/fedora:35
> +FROM registry.fedoraproject.org/fedora:37
>  
>  RUN dnf install -y nosync && \
>      echo -e '#!/bin/sh\n\
> diff --git a/tests/docker/dockerfiles/fedora-win64-cross.docker 
> b/tests/docker/dockerfiles/fedora-win64-cross.docker
> index 98c03dc13b..cabbf4edfc 100644
> --- a/tests/docker/dockerfiles/fedora-win64-cross.docker
> +++ b/tests/docker/dockerfiles/fedora-win64-cross.docker
> @@ -1,10 +1,10 @@
>  # THIS FILE WAS AUTO-GENERATED
>  #
> -#  $ lcitool dockerfile --layers all --cross mingw64 fedora-35 qemu
> +#  $ lcitool dockerfile --layers all --cross mingw64 fedora-37 qemu
>  #
>  # https://gitlab.com/libvirt/libvirt-ci
>  
> -FROM registry.fedoraproject.org/fedora:35
> +FROM registry.fedoraproject.org/fedora:37
>  
>  RUN dnf install -y nosync && \
>      echo -e '#!/bin/sh\n\
> diff --git a/tests/docker/dockerfiles/fedora.docker 
> b/tests/docker/dockerfiles/fedora.docker
> index d200c7fc10..f44b005000 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,10 +1,10 @@
>  # THIS FILE WAS AUTO-GENERATED
>  #
> -#  $ lcitool dockerfile --layers all fedora-35 qemu
> +#  $ lcitool dockerfile --layers all fedora-37 qemu
>  #
>  # https://gitlab.com/libvirt/libvirt-ci
>  
> -FROM registry.fedoraproject.org/fedora:35
> +FROM registry.fedoraproject.org/fedora:37

This breaks the oss fuzz build:

  Testing ./build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target- ...
  =================================================================
  ==5695==ERROR: LeakSanitizer: detected memory leaks
  Direct leak of 8 byte(s) in 1 object(s) allocated from:
      #0 0x559931c2a458 in operator new(unsigned long) 
(/builds/stsquad/qemu/build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target-+0xcff458) 
(BuildId: 4656f7dd1ff6e2faf418a79279f4e92db931ba28)
      #1 0x7f89125205b7  (/lib64/libtcmalloc_minimal.so.4+0xe5b7) (BuildId: 
8eab2cfc91caa7a82e480465400218310b7a341c)
      #2 0x7f8917d24cdd in call_init 
/usr/src/debug/glibc-2.36-9.fc37.x86_64/elf/dl-init.c:70:3
      #3 0x7f8917d24cdd in call_init 
/usr/src/debug/glibc-2.36-9.fc37.x86_64/elf/dl-init.c:26:1
      #4 0x7f8917d24dcb in _dl_init 
/usr/src/debug/glibc-2.36-9.fc37.x86_64/elf/dl-init.c:117:5
      #5 0x7f8917d3b8df in _dl_start_user (/lib64/ld-linux-x86-64.so.2+0x1b8df) 
(BuildId: bb6fec54c7521fddc569a2f4e141dfb97bf3acbe)
  SUMMARY: AddressSanitizer: 8 byte(s) leaked in 1 allocation(s).
  Cleaning up project directory and file based variables

The actual cause is that libglusterfs-devel pulls in gperftools-libs:

  [root@c0ca1c50f5cc /]# yum install libglusterfs-devel
  Last metadata expiration check: 0:04:40 ago on Thu 19 Jan 2023 12:24:51 PM 
UTC.
  Dependencies resolved.
  
=============================================================================================================================================================================
 Package                                          Architecture                  
       Version                                    Repository                    
        Size
  
=============================================================================================================================================================================Installing:
   libglusterfs-devel                               x86_64                      
         10.3-1.fc37                                fedora                      
         129 k
  Installing dependencies:
   gperftools-libs                                  x86_64                      
         2.9.1-4.fc37                               fedora                      
         307 k
   libgfrpc-devel                                   x86_64                      
         10.3-1.fc37                                fedora                      
          46 k
   libgfrpc0                                        x86_64                      
         10.3-1.fc37                                fedora                      
          59 k
   libgfxdr-devel                                   x86_64                      
         10.3-1.fc37                                fedora                      
         9.9 k
   libgfxdr0                                        x86_64                      
         10.3-1.fc37                                fedora                      
          31 k
   libglusterfs0                                    x86_64                      
         10.3-1.fc37                                fedora                      
         327 k

  Transaction Summary
  
=============================================================================================================================================================================Install
  7 Packages

Which brings in gperftools-libs an tcmalloc which then gets in the way
of our build. So either we drop glusterfs on fedora builds or we need
some way to avoid tcmalloc getting in the way.

To try and get the rest of the PR out of the way I think we should drop
this for now unless anyone has an easy solution?

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro