Re: [PATCH for-8.0 8/9] qdev: Remove qdev_reset_all() and qbus_reset_all()

[Philippe Mathieu-Daudé]

On 4/11/22 17:15, Peter Maydell wrote:
> Remove the qdev_reset_all() and qbus_reset_all() functions, now we
> have moved all the callers over to the new device_cold_reset() and
> bus_cold_reset() functions.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   include/hw/qdev-core.h | 26 --------------------
>   hw/core/qdev.c         | 54 ------------------------------------------
>   hw/core/trace-events   |  4 ----
>   3 files changed, 84 deletions(-)

> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 0806d8fcaaa..3b0f04c5c6d 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c

> -static int qbus_reset_one(BusState *bus, void *opaque)
> -{
> -    BusClass *bc = BUS_GET_CLASS(bus);
> -    trace_qbus_reset(bus, object_get_typename(OBJECT(bus)));
> -    if (bc->reset) {
> -        bc->reset(bus);
> -    }
> -    return 0;
> -}

> diff --git a/hw/core/trace-events b/hw/core/trace-events
> index 9b3ecce3b2f..d6ab5c74b90 100644
> --- a/hw/core/trace-events
> +++ b/hw/core/trace-events
> @@ -3,11 +3,7 @@ loader_write_rom(const char *name, uint64_t gpa, uint64_t size, 
> bool isrom) "%s:
>   
>   # qdev.c
>   qdev_reset(void *obj, const char *objtype) "obj=%p(%s)"
> -qdev_reset_all(void *obj, const char *objtype) "obj=%p(%s)"
> -qdev_reset_tree(void *obj, const char *objtype) "obj=%p(%s)"
>   qbus_reset(void *obj, const char *objtype) "obj=%p(%s)"

We can also remove the "qbus_reset" event.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> -qbus_reset_all(void *obj, const char *objtype) "obj=%p(%s)"
> -qbus_reset_tree(void *obj, const char *objtype) "obj=%p(%s)"
>   qdev_update_parent_bus(void *obj, const char *objtype, void *oldp, const char 
> *oldptype, void *newp, const char *newptype) "obj=%p(%s) old_parent=%p(%s) 
> new_parent=%p(%s)"
>   
>   # resettable.c