[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-8.0 1/9] hw/s390x/s390-pci-inst.c: Use device_cold_reset() to
From: |
Peter Maydell |
Subject: |
[PATCH for-8.0 1/9] hw/s390x/s390-pci-inst.c: Use device_cold_reset() to reset PCI devices |
Date: |
Fri, 4 Nov 2022 16:15:05 +0000 |
The semantic difference between the deprecated device_legacy_reset()
function and the newer device_cold_reset() function is that the new
function resets both the device itself and any qbuses it owns,
whereas the legacy function resets just the device itself and nothing
else.
In s390-pci-inst.c we use device_legacy_reset() to reset an
S390PCIBusDevice. This device doesn't have any child qbuses, so the
functions do the same thing and we can stop using the deprecated one.
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/s390x/s390-pci-inst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
index 20a9bcc7afb..16f5a3e81b4 100644
--- a/hw/s390x/s390-pci-inst.c
+++ b/hw/s390x/s390-pci-inst.c
@@ -272,7 +272,7 @@ int clp_service_call(S390CPU *cpu, uint8_t r2, uintptr_t ra)
stw_p(&ressetpci->hdr.rsp, CLP_RC_SETPCIFN_FHOP);
goto out;
}
- device_legacy_reset(DEVICE(pbdev));
+ device_cold_reset(DEVICE(pbdev));
pbdev->fh &= ~FH_MASK_ENABLE;
pbdev->state = ZPCI_FS_DISABLED;
stl_p(&ressetpci->fh, pbdev->fh);
--
2.25.1
- [PATCH for-8.0 9/9] hw: Remove device_legacy_reset(), (continued)
- [PATCH for-8.0 9/9] hw: Remove device_legacy_reset(), Peter Maydell, 2022/11/04
- [PATCH for-8.0 3/9] hw/audio/intel-hda: Drop unnecessary prototype, Peter Maydell, 2022/11/04
- [PATCH for-8.0 6/9] hw/hyperv/vmbus: Use device_cold_reset() and bus_cold_reset(), Peter Maydell, 2022/11/04
- [PATCH for-8.0 5/9] pci: Use device_cold_reset() and bus_cold_reset(), Peter Maydell, 2022/11/04
- [PATCH for-8.0 8/9] qdev: Remove qdev_reset_all() and qbus_reset_all(), Peter Maydell, 2022/11/04
- [PATCH for-8.0 1/9] hw/s390x/s390-pci-inst.c: Use device_cold_reset() to reset PCI devices,
Peter Maydell <=