[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC 3/7] migration: Block migration comment or code is wrong
From: |
Juan Quintela |
Subject: |
[RFC 3/7] migration: Block migration comment or code is wrong |
Date: |
Mon, 3 Oct 2022 05:15:56 +0200 |
And it appears that what is wrong is the code. During bulk stage we
need to make sure that some block is dirty, but no games with
max_size at all.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index b3d680af75..39ce4003c6 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -879,8 +879,8 @@ static void block_save_pending(void *opaque, uint64_t
max_size,
blk_mig_unlock();
/* Report at least one block pending during bulk phase */
- if (pending <= max_size && !block_mig_state.bulk_completed) {
- pending = max_size + BLK_MIG_BLOCK_SIZE;
+ if (!pending && !block_mig_state.bulk_completed) {
+ pending = BLK_MIG_BLOCK_SIZE;
}
trace_migration_block_save_pending(pending);
--
2.37.2
- [RFC 0/7] migration patches for VFIO, Juan Quintela, 2022/10/02
- [RFC 1/7] migration: Remove res_compatible parameter, Juan Quintela, 2022/10/02
- [RFC 3/7] migration: Block migration comment or code is wrong,
Juan Quintela <=
- [RFC 4/7] migration: Split save_live_pending() into state_pending_*, Juan Quintela, 2022/10/02
- [RFC 2/7] migration: No save_live_pending() method uses the QEMUFile parameter, Juan Quintela, 2022/10/02
- [RFC 5/7] migration: Remove unused threshold_size parameter, Juan Quintela, 2022/10/02
- [RFC 6/7] migration: simplify migration_iteration_run(), Juan Quintela, 2022/10/02
- [RFC 7/7] migration: call qemu_savevm_state_pending_exact() with the guest stopped, Juan Quintela, 2022/10/02