[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 12/13] hw/s390x/s390-skeys: rename skeys_enabled to skeys_are_
From: |
David Hildenbrand |
Subject: |
[PATCH v3 12/13] hw/s390x/s390-skeys: rename skeys_enabled to skeys_are_enabled |
Date: |
Fri, 3 Sep 2021 17:55:13 +0200 |
... and make it return a bool instead.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/s390x/s390-skeys-kvm.c | 4 ++--
hw/s390x/s390-skeys.c | 12 ++++++------
include/hw/s390x/storage-keys.h | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/s390x/s390-skeys-kvm.c b/hw/s390x/s390-skeys-kvm.c
index 1c4d805ad8..3ff9d94b80 100644
--- a/hw/s390x/s390-skeys-kvm.c
+++ b/hw/s390x/s390-skeys-kvm.c
@@ -15,7 +15,7 @@
#include "qemu/error-report.h"
#include "qemu/module.h"
-static int kvm_s390_skeys_enabled(S390SKeysState *ss)
+static bool kvm_s390_skeys_are_enabled(S390SKeysState *ss)
{
S390SKeysClass *skeyclass = S390_SKEYS_GET_CLASS(ss);
uint8_t single_key;
@@ -57,7 +57,7 @@ static void kvm_s390_skeys_class_init(ObjectClass *oc, void
*data)
S390SKeysClass *skeyclass = S390_SKEYS_CLASS(oc);
DeviceClass *dc = DEVICE_CLASS(oc);
- skeyclass->skeys_enabled = kvm_s390_skeys_enabled;
+ skeyclass->skeys_are_enabled = kvm_s390_skeys_are_enabled;
skeyclass->get_skeys = kvm_s390_skeys_get;
skeyclass->set_skeys = kvm_s390_skeys_set;
diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c
index db73e9091d..9e994a5582 100644
--- a/hw/s390x/s390-skeys.c
+++ b/hw/s390x/s390-skeys.c
@@ -82,7 +82,7 @@ void hmp_info_skeys(Monitor *mon, const QDict *qdict)
int r;
/* Quick check to see if guest is using storage keys*/
- if (!skeyclass->skeys_enabled(ss)) {
+ if (!skeyclass->skeys_are_enabled(ss)) {
monitor_printf(mon, "Error: This guest is not using storage keys\n");
return;
}
@@ -128,7 +128,7 @@ void qmp_dump_skeys(const char *filename, Error **errp)
FILE *f;
/* Quick check to see if guest is using storage keys*/
- if (!skeyclass->skeys_enabled(ss)) {
+ if (!skeyclass->skeys_are_enabled(ss)) {
error_setg(errp, "This guest is not using storage keys - "
"nothing to dump");
return;
@@ -200,9 +200,9 @@ static void qemu_s390_skeys_init(Object *obj)
skeys->keydata = g_malloc0(skeys->key_count);
}
-static int qemu_s390_skeys_enabled(S390SKeysState *ss)
+static bool qemu_s390_skeys_are_enabled(S390SKeysState *ss)
{
- return 1;
+ return true;
}
static int qemu_s390_skeys_set(S390SKeysState *ss, uint64_t start_gfn,
@@ -250,7 +250,7 @@ static void qemu_s390_skeys_class_init(ObjectClass *oc,
void *data)
S390SKeysClass *skeyclass = S390_SKEYS_CLASS(oc);
DeviceClass *dc = DEVICE_CLASS(oc);
- skeyclass->skeys_enabled = qemu_s390_skeys_enabled;
+ skeyclass->skeys_are_enabled = qemu_s390_skeys_are_enabled;
skeyclass->get_skeys = qemu_s390_skeys_get;
skeyclass->set_skeys = qemu_s390_skeys_set;
@@ -277,7 +277,7 @@ static void s390_storage_keys_save(QEMUFile *f, void
*opaque)
int error = 0;
uint8_t *buf;
- if (!skeyclass->skeys_enabled(ss)) {
+ if (!skeyclass->skeys_are_enabled(ss)) {
goto end_stream;
}
diff --git a/include/hw/s390x/storage-keys.h b/include/hw/s390x/storage-keys.h
index 2888d42d0b..eb091842c8 100644
--- a/include/hw/s390x/storage-keys.h
+++ b/include/hw/s390x/storage-keys.h
@@ -28,7 +28,7 @@ struct S390SKeysState {
struct S390SKeysClass {
DeviceClass parent_class;
- int (*skeys_enabled)(S390SKeysState *ks);
+ bool (*skeys_are_enabled)(S390SKeysState *ks);
int (*get_skeys)(S390SKeysState *ks, uint64_t start_gfn, uint64_t count,
uint8_t *keys);
int (*set_skeys)(S390SKeysState *ks, uint64_t start_gfn, uint64_t count,
--
2.31.1
- [PATCH v3 05/13] s390x/mmu_helper: no need to pass access type to mmu_translate_asce(), (continued)
- [PATCH v3 05/13] s390x/mmu_helper: no need to pass access type to mmu_translate_asce(), David Hildenbrand, 2021/09/03
- [PATCH v3 06/13] s390x/mmu_helper: fixup mmu_translate() documentation, David Hildenbrand, 2021/09/03
- [PATCH v3 07/13] s390x/mmu_helper: move address validation into mmu_translate*(), David Hildenbrand, 2021/09/03
- [PATCH v3 08/13] s390x/mmu_helper: avoid setting the storage key if nothing changed, David Hildenbrand, 2021/09/03
- [PATCH v3 09/13] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to migrate, David Hildenbrand, 2021/09/03
- [PATCH v3 10/13] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to dump, David Hildenbrand, 2021/09/03
- [PATCH v3 11/13] hw/s390x/s390-skeys: check if an address is valid before dumping the key, David Hildenbrand, 2021/09/03
- [PATCH v3 13/13] hw/s390x/s390-skeys: lazy storage key enablement under TCG, David Hildenbrand, 2021/09/03
- [PATCH v3 12/13] hw/s390x/s390-skeys: rename skeys_enabled to skeys_are_enabled,
David Hildenbrand <=
- Re: [PATCH v3 00/13] s390x: skey related fixes, cleanups, and memory device preparations, Thomas Huth, 2021/09/07