[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 10/13] hw/s390x/s390-skeys: use memory mapping to detect which
From: |
David Hildenbrand |
Subject: |
[PATCH v3 10/13] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to dump |
Date: |
Fri, 3 Sep 2021 17:55:11 +0200 |
Handle it similar to migration. Assert that we're holding the BQL, to
make sure we don't see concurrent modifications.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/s390x/s390-skeys.c | 50 ++++++++++++++++++++++++++-----------------
1 file changed, 30 insertions(+), 20 deletions(-)
diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c
index 250685a95a..56a47fe180 100644
--- a/hw/s390x/s390-skeys.c
+++ b/hw/s390x/s390-skeys.c
@@ -110,11 +110,10 @@ void qmp_dump_skeys(const char *filename, Error **errp)
{
S390SKeysState *ss = s390_get_skeys_device();
S390SKeysClass *skeyclass = S390_SKEYS_GET_CLASS(ss);
- MachineState *ms = MACHINE(qdev_get_machine());
- const uint64_t total_count = ms->ram_size / TARGET_PAGE_SIZE;
- uint64_t handled_count = 0, cur_count;
+ GuestPhysBlockList guest_phys_blocks;
+ GuestPhysBlock *block;
+ uint64_t pages, gfn;
Error *lerr = NULL;
- vaddr cur_gfn = 0;
uint8_t *buf;
int ret;
int fd;
@@ -145,28 +144,39 @@ void qmp_dump_skeys(const char *filename, Error **errp)
goto out;
}
- /* we'll only dump initial memory for now */
- while (handled_count < total_count) {
- /* Calculate how many keys to ask for & handle overflow case */
- cur_count = MIN(total_count - handled_count, S390_SKEYS_BUFFER_SIZE);
+ assert(qemu_mutex_iothread_locked());
+ guest_phys_blocks_init(&guest_phys_blocks);
+ guest_phys_blocks_append(&guest_phys_blocks);
- ret = skeyclass->get_skeys(ss, cur_gfn, cur_count, buf);
- if (ret < 0) {
- error_setg(errp, "get_keys error %d", ret);
- goto out_free;
- }
+ QTAILQ_FOREACH(block, &guest_phys_blocks.head, next) {
+ assert(QEMU_IS_ALIGNED(block->target_start, TARGET_PAGE_SIZE));
+ assert(QEMU_IS_ALIGNED(block->target_end, TARGET_PAGE_SIZE));
- /* write keys to stream */
- write_keys(f, buf, cur_gfn, cur_count, &lerr);
- if (lerr) {
- goto out_free;
- }
+ gfn = block->target_start / TARGET_PAGE_SIZE;
+ pages = (block->target_end - block->target_start) / TARGET_PAGE_SIZE;
- cur_gfn += cur_count;
- handled_count += cur_count;
+ while (pages) {
+ const uint64_t cur_pages = MIN(pages, S390_SKEYS_BUFFER_SIZE);
+
+ ret = skeyclass->get_skeys(ss, gfn, cur_pages, buf);
+ if (ret < 0) {
+ error_setg_errno(errp, -ret, "get_keys error");
+ goto out_free;
+ }
+
+ /* write keys to stream */
+ write_keys(f, buf, gfn, cur_pages, &lerr);
+ if (lerr) {
+ goto out_free;
+ }
+
+ gfn += cur_pages;
+ pages -= cur_pages;
+ }
}
out_free:
+ guest_phys_blocks_free(&guest_phys_blocks);
error_propagate(errp, lerr);
g_free(buf);
out:
--
2.31.1
- Re: [PATCH v3 02/13] s390x/tcg: fix ignoring bit 63 when setting the storage key in SSKE, (continued)
- [PATCH v3 03/13] s390x/tcg: convert real to absolute address for RRBE, SSKE and ISKE, David Hildenbrand, 2021/09/03
- [PATCH v3 04/13] s390x/tcg: check for addressing exceptions for RRBE, SSKE and ISKE, David Hildenbrand, 2021/09/03
- [PATCH v3 05/13] s390x/mmu_helper: no need to pass access type to mmu_translate_asce(), David Hildenbrand, 2021/09/03
- [PATCH v3 06/13] s390x/mmu_helper: fixup mmu_translate() documentation, David Hildenbrand, 2021/09/03
- [PATCH v3 07/13] s390x/mmu_helper: move address validation into mmu_translate*(), David Hildenbrand, 2021/09/03
- [PATCH v3 08/13] s390x/mmu_helper: avoid setting the storage key if nothing changed, David Hildenbrand, 2021/09/03
- [PATCH v3 09/13] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to migrate, David Hildenbrand, 2021/09/03
- [PATCH v3 10/13] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to dump,
David Hildenbrand <=
- [PATCH v3 11/13] hw/s390x/s390-skeys: check if an address is valid before dumping the key, David Hildenbrand, 2021/09/03
- [PATCH v3 13/13] hw/s390x/s390-skeys: lazy storage key enablement under TCG, David Hildenbrand, 2021/09/03
- [PATCH v3 12/13] hw/s390x/s390-skeys: rename skeys_enabled to skeys_are_enabled, David Hildenbrand, 2021/09/03
- Re: [PATCH v3 00/13] s390x: skey related fixes, cleanups, and memory device preparations, Thomas Huth, 2021/09/07