Re: [PATCH v3 1/1] vl/s390x: fixup ram sizes for compat machines

[Christian Borntraeger]

On 02.04.20 14:05, Igor Mammedov wrote:
> On Thu, 2 Apr 2020 13:42:22 +0200
> Christian Borntraeger <address@hidden> wrote:
> 
>> On 02.04.20 13:39, Igor Mammedov wrote:
>> [...]
>>>>>     
>>>>>> +                    "MB to match machine restrictions. Consider 
>>>>>> updating "
>>>>>> +                    "the guest definition.i\n", sz / MiB, newsz / MiB); 
>>>>>>      
>>>>>
>>>>> also it might be better to use size_to_str() to format numbers    
>>>>
>>>> The text explicitly talks about 'MB'... not sure if it would be
>>>> confusing if the user specified MB and ended up with GB or so in this
>>>> message.  
>>>
>>> MB can be dropped, since it still might not match what user specified with 
>>> -m
>>> it could be specified in b/kb/mb/gb over there
>>>
>>> so I'd drop MB and print value size_to_str() returns
>>> (it will add appropriate suffix if I'm not mistaken)

Another thing: size_to_str is also do rounding (whenever the integer part is 
>1000).
Doesnt this result in potential messages where both numbers are the same?