Re: [PATCH v9 00/15] s390x: Protected Virtualization support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v9 00/15] s390x: Protected Virtualization support
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
5091111 s390x: Add unpack facility feature to GA1
3017941 docs: Add protvirt docs
8971626 s390x: protvirt: Handle SIGP store status correctly
80534f0 s390x: protvirt: Move IO control structures over SIDA
6469c9e s390x: protvirt: Disable address checks for PV guest IO emulation
fcf17b9 s390x: protvirt: Move diag 308 data over SIDA
bc7ccf1 s390x: protvirt: Set guest IPL PSW
0dc6509 s390x: protvirt: SCLP interpretation
55b33fb s390x: protvirt: Move STSI data over SIDAD
cd885bc s390x: Add SIDA memory ops
420161d s390x: protvirt: KVM intercept changes
df0e73f s390x: protvirt: Inhibit balloon when switching to protected mode
1a573ba s390x: protvirt: Add migration blocker
f214aa5 s390x: protvirt: Support unpack facility
9eb0129 Sync pv

=== OUTPUT BEGIN ===
1/15 Checking commit 9eb01294c7d7 (Sync pv)
2/15 Checking commit f214aa5c8796 (s390x: protvirt: Support unpack facility)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#274: 
new file mode 100644

WARNING: line over 80 characters
#600: FILE: include/hw/s390x/pv.h:48:
+static inline int s390_pv_set_sec_parms(uint64_t origin, uint64_t length) { 
return 0; }

ERROR: line over 90 characters
#601: FILE: include/hw/s390x/pv.h:49:
+static inline int s390_pv_unpack(uint64_t addr, uint64_t size, uint64_t tweak) 
{ return 0; }

total: 1 errors, 2 warnings, 642 lines checked

Patch 2/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/15 Checking commit 1a573ba2b449 (s390x: protvirt: Add migration blocker)
4/15 Checking commit df0e73f31901 (s390x: protvirt: Inhibit balloon when 
switching to protected mode)
5/15 Checking commit 420161d14911 (s390x: protvirt: KVM intercept changes)
ERROR: switch and case should be at the same indent
#48: FILE: target/s390x/kvm.c:1696:
     switch (icpt_code) {
[...]
+        case ICPT_PV_INSTR:
+        case ICPT_PV_INSTR_NOTIFICATION:

total: 1 errors, 0 warnings, 16 lines checked

Patch 5/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/15 Checking commit cd885bcb5756 (s390x: Add SIDA memory ops)
7/15 Checking commit 55b33fb822b7 (s390x: protvirt: Move STSI data over SIDAD)
8/15 Checking commit 0dc650979f79 (s390x: protvirt: SCLP interpretation)
9/15 Checking commit bc7ccf1d1d99 (s390x: protvirt: Set guest IPL PSW)
10/15 Checking commit fcf17b96e7cc (s390x: protvirt: Move diag 308 data over 
SIDA)
11/15 Checking commit 6469c9e84dab (s390x: protvirt: Disable address checks for 
PV guest IO emulation)
12/15 Checking commit 80534f0309d2 (s390x: protvirt: Move IO control structures 
over SIDA)
13/15 Checking commit 8971626e3e69 (s390x: protvirt: Handle SIGP store status 
correctly)
14/15 Checking commit 3017941d6e2c (docs: Add protvirt docs)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 60 lines checked

Patch 14/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/15 Checking commit 509111178918 (s390x: Add unpack facility feature to GA1)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden