Re: [PATCH 1/2] tcg: Search includes from the project root source direct

qemu-s390x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] tcg: Search includes from the project root source direct

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH 1/2] tcg: Search includes from the project root source directory
Date:	Mon, 30 Dec 2019 15:02:01 +0100
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/30/19 11:33 AM, Paolo Bonzini wrote:

Il lun 30 dic 2019, 09:59 Philippe Mathieu-Daudé <address@hidden<mailto:address@hidden>> ha scritto:
     > I'd prefer not changing those files.

    OK, I'll wait to see what Richard/Markus prefer.
I think it's best if you keep the include directives as-is for filesonly needed from tcg/, and move the other headers (those that are neededfrom other directories only) to include/tcg.

I thought moving headers to include/tcg would diverge too much fromlibtcg, but this project already did it, so why not:

https://github.com/S2E/libtcg/tree/master/include/tcg

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 0/2] tcg: Include tcg files using tcg/ dirname, reduce cpp search path list, Philippe Mathieu-Daudé, 2019/12/30
- [PATCH 1/2] tcg: Search includes from the project root source directory, Philippe Mathieu-Daudé, 2019/12/30
  - Re: [PATCH 1/2] tcg: Search includes from the project root source directory, Stefan Weil, 2019/12/30
    - Re: [PATCH 1/2] tcg: Search includes from the project root source directory, Philippe Mathieu-Daudé, 2019/12/30
    - Re: [PATCH 1/2] tcg: Search includes from the project root source directory, Paolo Bonzini, 2019/12/30
    - Re: [PATCH 1/2] tcg: Search includes from the project root source directory, Philippe Mathieu-Daudé <=
    - Re: [PATCH 1/2] tcg: Search includes from the project root source directory, Philippe Mathieu-Daudé, 2019/12/30
    - Re: [PATCH 1/2] tcg: Search includes from the project root source directory, Paolo Bonzini, 2019/12/30
- [PATCH 2/2] configure: Remove tcg/ from the preprocessor include search list, Philippe Mathieu-Daudé, 2019/12/30

Prev by Date: Re: [PATCH 1/2] tcg: Search includes from the project root source directory
Next by Date: Re: [PATCH 1/2] tcg: Search includes from the project root source directory
Previous by thread: Re: [PATCH 1/2] tcg: Search includes from the project root source directory
Next by thread: Re: [PATCH 1/2] tcg: Search includes from the project root source directory
Index(es):
- Date
- Thread