Re: [PATCH 1/2] tcg: Search includes from the project root source directory

[Philippe Mathieu-Daudé]

Hi Stefan,

On 12/30/19 10:53 AM, Stefan Weil wrote:
> Am 30.12.19 um 10:08 schrieb Philippe Mathieu-Daudé:
>
> [...]
>
> >   tcg/tcg-op.h                  | 2 +-
> >   tcg/tcg.h                     | 4 ++--
> >   tcg/tcg-common.c              | 2 +-
> >   tcg/tcg-op-gvec.c             | 8 ++++----
> >   tcg/tcg-op-vec.c              | 6 +++---
> >   tcg/tcg-op.c                  | 6 +++---
> >   tcg/tcg.c                     | 2 +-
> >   tcg/tci.c                     | 2 +-
>
>
> Source files in the tcg directory should not need any change because
> they find include files in the same directory without searching.
>
> If we add a tcg/ include file prefix for them as well, that has the
> advantage that it might look prettier and more uniform, but it has the
> disadvantage of requiring a search by the preprocessor.

Yeah, I was not sure about these specific files. My first attempt was 
without modifying them, but then I thought it would be better to keep 
the codebase uniform, as you said.

> I'd prefer not changing those files.

OK, I'll wait to see what Richard/Markus prefer.

> Regards and best wished for 2020

Thanks ;)