Re: [PATCH v4 6/6] s390x: kvm: Make kvm_sclp_service_call void

[Cornelia Huck]

On Wed, 27 Nov 2019 19:38:06 +0100
Janosch Frank <address@hidden> wrote:

> On 11/27/19 7:25 PM, Janosch Frank wrote:
> > 
> > There's 0 (initiated), busy and operational and as far as I know we
> > implement neither.  
> 
> That came out wrong...
> s/operational/not operational/
> 
> We only implement "command initiated" / cc = 0
> We can never have busy, because we handle sclp calls synchronously.
> The spec does not give any indication when we could return "not
> operational". I guess that's just a free pass for hypervisors.

Regardless, setcc(cpu, r) also feels a bit cleaner to me...

> 
> > sclp_service_call() returns either 0 or -PGM_CODE, so we don't need to
> > check when we're after the pgm injection code.  
> 
>

pgpnBDEXHpeC7.pgp
Description: OpenPGP digital signature