[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/15] s390x: protvirt: Disable address checks for PV guest I
|
From: |
Cornelia Huck |
|
Subject: |
Re: [PATCH 14/15] s390x: protvirt: Disable address checks for PV guest IO emulation |
|
Date: |
Thu, 28 Nov 2019 17:18:32 +0100 |
On Thu, 28 Nov 2019 17:10:38 +0100
Janosch Frank <address@hidden> wrote:
> On 11/28/19 4:28 PM, Thomas Huth wrote:
> > Would it make sense to hide all these changes in decode_basedisp_s()
> > instead? ... so that decode_basedisp_s() returns 0 if env->pv == true ?
> > ... or are there still cases where we need real values from
> > decode_basedisp_s() in case of env->pv==true?
>
> I'd like to keep decode_basedisp_s() as is, but how about a static
> function in ioinst.c called something like get_address_from_regs()?
>
> It'll call decode_basedisp_s() or return 0.
We could do something like that; but do we ever get there for other
instruction formats as well? It feels a bit odd to single out this one.
pgpdkiWT3aRzM.pgp
Description: OpenPGP digital signature
[PATCH 15/15] s390x: protvirt: Handle SIGP store status correctly, Janosch Frank, 2019/11/20
Re: [PATCH 00/15] s390x: Protected Virtualization support, Cornelia Huck, 2019/11/20
Re: [PATCH 00/15] s390x: Protected Virtualization support, Daniel P . Berrangé, 2019/11/29