[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL 1/7] s390x/tcg: Fix VERIM with 32/64 bit elements
From: |
Cornelia Huck |
Subject: |
[qemu-s390x] [PULL 1/7] s390x/tcg: Fix VERIM with 32/64 bit elements |
Date: |
Thu, 22 Aug 2019 15:58:33 +0200 |
From: David Hildenbrand <address@hidden>
Wrong order of operands. The constant always comes last. Makes QEMU crash
reliably on specific git fetch invocations.
Reported-by: Stefano Brivio <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Fixes: 5c4b0ab460ef ("s390x/tcg: Implement VECTOR ELEMENT ROTATE AND INSERT
UNDER MASK")
Cc: address@hidden
Signed-off-by: Cornelia Huck <address@hidden>
---
target/s390x/translate_vx.inc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/translate_vx.inc.c b/target/s390x/translate_vx.inc.c
index 41d5cf869f94..0caddb3958cd 100644
--- a/target/s390x/translate_vx.inc.c
+++ b/target/s390x/translate_vx.inc.c
@@ -213,7 +213,7 @@ static void get_vec_element_ptr_i64(TCGv_ptr ptr, uint8_t
reg, TCGv_i64 enr,
vec_full_reg_offset(v3), ptr, 16, 16, data, fn)
#define gen_gvec_3i(v1, v2, v3, c, gen) \
tcg_gen_gvec_3i(vec_full_reg_offset(v1), vec_full_reg_offset(v2), \
- vec_full_reg_offset(v3), c, 16, 16, gen)
+ vec_full_reg_offset(v3), 16, 16, c, gen)
#define gen_gvec_4(v1, v2, v3, v4, gen) \
tcg_gen_gvec_4(vec_full_reg_offset(v1), vec_full_reg_offset(v2), \
vec_full_reg_offset(v3), vec_full_reg_offset(v4), \
--
2.20.1
- [qemu-s390x] [PULL 0/7] First batch of s390x changes for 4.2, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PATCH for-4.1?] compat: disable edid on virtio-gpu base device, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 1/7] s390x/tcg: Fix VERIM with 32/64 bit elements,
Cornelia Huck <=
- [qemu-s390x] [PULL 2/7] s390x/mmu: Trace the right value if setting/getting the storage key fails, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 3/7] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug(), Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 4/7] s390x/tcg: Rework MMU selection for instruction fetches, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 5/7] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 6/7] s390x/mmu: Better storage key reference and change bit handling, Cornelia Huck, 2019/08/22
- [qemu-s390x] [PULL 7/7] s390x/mmu: Factor out storage key handling, Cornelia Huck, 2019/08/22
- Re: [qemu-s390x] [PULL 0/7] First batch of s390x changes for 4.2, Peter Maydell, 2019/08/23