[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PATCH-for-4.2 v1 4/6] s390x/mmu: Trace the right value if
From: |
David Hildenbrand |
Subject: |
[qemu-s390x] [PATCH-for-4.2 v1 4/6] s390x/mmu: Trace the right value if setting/getting the storage key fails |
Date: |
Mon, 12 Aug 2019 13:27:35 +0200 |
We want to trace the actual return value, not "0".
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/mmu_helper.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
index 2c9bb3acc0..227a822e42 100644
--- a/target/s390x/mmu_helper.c
+++ b/target/s390x/mmu_helper.c
@@ -415,7 +415,8 @@ nodat:
*raddr = mmu_real2abs(env, *raddr);
if (*raddr < ram_size) {
- if (skeyclass->get_skeys(ss, *raddr / TARGET_PAGE_SIZE, 1, &key)) {
+ r = skeyclass->get_skeys(ss, *raddr / TARGET_PAGE_SIZE, 1, &key);
+ if (r) {
trace_get_skeys_nonzero(r);
return 0;
}
@@ -428,7 +429,8 @@ nodat:
key |= SK_C;
}
- if (skeyclass->set_skeys(ss, *raddr / TARGET_PAGE_SIZE, 1, &key)) {
+ r = skeyclass->set_skeys(ss, *raddr / TARGET_PAGE_SIZE, 1, &key);
+ if (r) {
trace_set_skeys_nonzero(r);
return 0;
}
--
2.21.0
- Re: [qemu-s390x] [PATCH-for-4.2 v1 1/6] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug(), (continued)
Re: [qemu-s390x] [PATCH-for-4.2 v1 1/6] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug(), Cornelia Huck, 2019/08/13
[qemu-s390x] [PATCH-for-4.2 v1 2/6] s390x/tcg: Rework MMU selection for instruction fetches, David Hildenbrand, 2019/08/12
Re: [qemu-s390x] [PATCH-for-4.2 v1 2/6] s390x/tcg: Rework MMU selection for instruction fetches, Cornelia Huck, 2019/08/13
[qemu-s390x] [PATCH-for-4.2 v1 3/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE, David Hildenbrand, 2019/08/12
[qemu-s390x] [PATCH-for-4.2 v1 4/6] s390x/mmu: Trace the right value if setting/getting the storage key fails,
David Hildenbrand <=
[qemu-s390x] [PATCH-for-4.2 v1 5/6] s390x/mmu: Better storage key reference and change bit handling, David Hildenbrand, 2019/08/12
[qemu-s390x] [PATCH-for-4.2 v1 6/6] s390x/mmu: Factor out storage key handling, David Hildenbrand, 2019/08/12