[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v2 5/5] build: don't build hardware objects with
|
From: |
Laurent Vivier |
|
Subject: |
Re: [qemu-s390x] [PATCH v2 5/5] build: don't build hardware objects with linux-user |
|
Date: |
Thu, 28 Mar 2019 17:11:13 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 28/03/2019 17:08, Paolo Bonzini wrote:
> On 28/03/19 17:01, Laurent Vivier wrote:
>> +ifeq ($(CONFIG_BLOCK),y)
>> trace-events-subdirs += authz
>> trace-events-subdirs += block
>> -trace-events-subdirs += crypto
>> +trace-events-subdirs += io
>> +trace-events-subdirs += nbd
>> +trace-events-subdirs += scsi
>> +trace-events-subdirs += hw/display # needed by qemu-edid
>> +endif
>
> It's a bit strange to put hw/display here. Maybe just leave it
> unconditional?
I agree.
Thanks,
Laurent
- [qemu-s390x] [PATCH v2 0/5] build: cleanup in Makefile.objs, Laurent Vivier, 2019/03/28
- [qemu-s390x] [PATCH v2 5/5] build: don't build hardware objects with linux-user, Laurent Vivier, 2019/03/28
- [qemu-s390x] [PATCH v2 2/5] build: replace GENERATED_FILES by generated-files-y, Laurent Vivier, 2019/03/28
- [qemu-s390x] [PATCH v2 3/5] configure: qemu-ga is only needed with softmmu targets, Laurent Vivier, 2019/03/28
- [qemu-s390x] [PATCH v2 1/5] trace: only include trace-event-subdirs when they are needed, Laurent Vivier, 2019/03/28
- Re: [qemu-s390x] [PATCH v2 0/5] build: cleanup in Makefile.objs, Paolo Bonzini, 2019/03/28
- [qemu-s390x] [PATCH v2 4/5] build: chardev is only needed for softmmu targets, Laurent Vivier, 2019/03/28