Re: [qemu-s390x] [PATCH v2 0/5] build: cleanup in Makefile.objs

[Paolo Bonzini]

On 28/03/19 17:00, Laurent Vivier wrote:
> This cleanup removes hardware objects from the list of files to be
> built for linux-user only targets.
> 
> It also builds traces files only when the related file is built.
> 
> Tested with all combinations of --{disable,enable}-{system,user,tools}
> 
> v2:
>   - add CONFIG_TOOLS and CONFIG_BLOCK
>   - replace GENERATED_FILES by generated-files-y
>     and use generated-files-${CONFIG_TRACE_UST} and
>     generated-files-${CONFIG_SOFTMMU}
>   - move chardev-obj-y from SUBDIR_RULES to SOFTMMU_SUBDIR_RULES
>   - use $(CONFIG_BLOCK) in tests/Makefile.include
>   - disable qemu-ga with linux-user only
> 
> Laurent Vivier (5):
>   trace: only include trace-event-subdirs when they are needed
>   build: replace GENERATED_FILES by generated-files-y
>   configure: qemu-ga is only needed with softmmu targets
>   build: chardev is only needed for softmmu targets
>   build: don't build hardware objects with linux-user
> 
>  Makefile                   |  43 +++++++-------
>  Makefile.objs              |  22 ++++---
>  Makefile.target            |   6 +-
>  configure                  |   4 +-
>  target/s390x/Makefile.objs |   2 +-
>  tests/Makefile.include     | 116 ++++++++++++++++++-------------------
>  6 files changed, 102 insertions(+), 91 deletions(-)
> 

Looks good to me, apart from the slightly weird CONFIG_BLOCK usage for
hw/display.

Paolo