[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH] s390x: always provide pci support
|
From: |
Cornelia Huck |
|
Subject: |
Re: [qemu-s390x] [PATCH] s390x: always provide pci support |
|
Date: |
Mon, 11 Feb 2019 15:57:14 +0100 |
On Mon, 11 Feb 2019 15:05:46 +0100
Christian Borntraeger <address@hidden> wrote:
> On 11.02.2019 12:32, Cornelia Huck wrote:
> > We tried to make pci support optional on s390x in the past;
> > unfortunately, we still require the s390 phb to be created
> > unconditionally due to backwards compatibility issues.
> >
> > Instead of sinking more effort into this (including compat
> > handling for older machines etc.) for non-obvious gains, let's
> > just make CONFIG_PCI something that is always set on s390x.
> >
> > Note that you can still fence off pci for the _guest_ if you
> > provide a cpu model without the zpci feature.
> >
> > Signed-off-by: Cornelia Huck <address@hidden>
>
> Acked-by: Christian Borntraeger <address@hidden>
>
> The previous attempts of making it configurable caused more pain than
> benefit.
I think we've reaped all the benefits of the attempt already (making
relevant instructions check for the zpci feature bit).