|
| From: | David Hildenbrand |
| Subject: | Re: [qemu-s390x] [PATCH v1 2/8] spapr: no need to verify the node |
| Date: | Fri, 8 Jun 2018 11:24:51 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
>>>> +1 for error_abort, even if it takes another line. >>> +1 for error_abort >>> call shouldn't fail, but if does it won't be silently ignored >>> and introduce undefined behavior. >> >> Maybe we should fix the others that pass in NULL. >> >> (no, not me :D - I'm already busy with your requested pre_plug handling) > Add it to wiki page for bite sized tasks? Done. -- Thanks, David / dhildenb
| [Prev in Thread] | Current Thread | [Next in Thread] |