[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL 06/15] pc-bios/s390-ccw: size_t should be unsigned
From: |
Cornelia Huck |
Subject: |
[qemu-s390x] [PULL 06/15] pc-bios/s390-ccw: size_t should be unsigned |
Date: |
Fri, 4 May 2018 09:25:05 +0200 |
From: Thomas Huth <address@hidden>
"size_t" should be an unsigned type according to the C standard.
Thus we should also use this convention in the s390-ccw firmware to avoid
confusion. I checked the sources, and apart from one spot in libc.c, the
code should all be fine with this change.
Buglink: https://bugs.launchpad.net/qemu/+bug/1753437
Reviewed-by: Christian Borntraeger <address@hidden>
Reviewed-by: Halil Pasic <address@hidden>
Reviewed-by: Collin Walling <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
pc-bios/s390-ccw/libc.c | 2 +-
pc-bios/s390-ccw/libc.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/pc-bios/s390-ccw/libc.c b/pc-bios/s390-ccw/libc.c
index 38ea77d7aa..a786566c4c 100644
--- a/pc-bios/s390-ccw/libc.c
+++ b/pc-bios/s390-ccw/libc.c
@@ -63,7 +63,7 @@ uint64_t atoui(const char *str)
*/
char *uitoa(uint64_t num, char *str, size_t len)
{
- size_t num_idx = 1; /* account for NUL */
+ long num_idx = 1; /* account for NUL */
uint64_t tmp = num;
IPL_assert(str != NULL, "uitoa: no space allocated to store string");
diff --git a/pc-bios/s390-ccw/libc.h b/pc-bios/s390-ccw/libc.h
index 63ece70c6b..818517ff5d 100644
--- a/pc-bios/s390-ccw/libc.h
+++ b/pc-bios/s390-ccw/libc.h
@@ -12,7 +12,7 @@
#ifndef S390_CCW_LIBC_H
#define S390_CCW_LIBC_H
-typedef long size_t;
+typedef unsigned long size_t;
typedef int bool;
typedef unsigned char uint8_t;
typedef unsigned short uint16_t;
--
2.14.3
- [qemu-s390x] [PULL 00/15] first s390x update for 2.13, Cornelia Huck, 2018/05/04
- [qemu-s390x] [PULL 01/15] s390x: introduce 2.13 compat machine, Cornelia Huck, 2018/05/04
- [qemu-s390x] [PULL 03/15] vfio-ccw: introduce vfio_ccw_get_device(), Cornelia Huck, 2018/05/04
- [qemu-s390x] [PULL 02/15] s390x/sclp: extend SCLP event masks to 64 bits, Cornelia Huck, 2018/05/04
- [qemu-s390x] [PULL 04/15] s390x/kvm: cleanup calls to cpu_synchronize_state(), Cornelia Huck, 2018/05/04
- [qemu-s390x] [PULL 06/15] pc-bios/s390-ccw: size_t should be unsigned,
Cornelia Huck <=
- [qemu-s390x] [PULL 05/15] hw/s390x: Allow to configure the consoles with the "-serial" parameter, Cornelia Huck, 2018/05/04
- [qemu-s390x] [PULL 07/15] pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES, Cornelia Huck, 2018/05/04
- [qemu-s390x] [PULL 08/15] pc-bios/s390-ccw: fix loadparm initialization and int conversion, Cornelia Huck, 2018/05/04
- [qemu-s390x] [PULL 09/15] pc-bios/s390-ccw: fix non-sequential boot entries (eckd), Cornelia Huck, 2018/05/04
- [qemu-s390x] [PULL 10/15] pc-bios/s390-ccw: fix non-sequential boot entries (enum), Cornelia Huck, 2018/05/04