Re: [qemu-s390x] [Qemu-devel] [PATCH 04/67] s390x: drop an unused include

[Thomas Huth]

On 03.05.2018 21:50, Michael S. Tsirkin wrote:
> we just need a struct name, let's add a forward
> declaration instead of an include.
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  include/hw/s390x/sclp.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
> index f9db243..6e65150 100644
> --- a/include/hw/s390x/sclp.h
> +++ b/include/hw/s390x/sclp.h
> @@ -16,7 +16,8 @@
>  
>  #include "hw/sysbus.h"
>  #include "hw/qdev.h"
> -#include "target/s390x/cpu-qom.h"
> +
> +typedef struct CPUS390XState CPUS390XState;

IIRC you have to use include/qemu/typedefs.h instead to avoid trouble
with older versions of GCC.

 Thomas