[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH for 2.13 v2 00/20] linux-user: move
From: |
Laurent Vivier |
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH for 2.13 v2 00/20] linux-user: move arch specific parts to arch directories |
Date: |
Wed, 28 Mar 2018 16:52:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
Le 28/03/2018 à 16:41, Alex Bennée a écrit :
>
> Laurent Vivier <address@hidden> writes:
>
>> Some files like signal.c are really hard to read
>> because all architectures are mixed in the same
>> file.
>>
>> This series moves from signal.c these parts to
>> the architecture dedicated directories in linux-user.
>> Moreover, this allows to compare easier functions
>> between architectures (it helps to debug problems).
>> Adding new functions for a new architecture will
>> be facilitated too.
>>
>> checkpatch.pl is not happy... but I only want to
>> move code from a file to another. I don't want
>> to change the content of the parts I move.
>
> I think de-tabifying is worth it as it's a whitespace fix. Sure you can
> leave everything else.
>
> Anyway for the rest of the series it looks good to me (although I only
> tested ARM).
>
> Reviewed-by: Alex Bennée <address@hidden>
Thank you,
For testing, I have "debootstrap"ed the following architectures:
stretch: s390x ppc64le mipsel mips64el mips arm aarch64
jessie: ppc
lenny: hppa
sid: m68k ppc64 sh4
I've tried sparc32plus, sparc64 and alpha but they are already broken
without this patch series.
For the other architectures, I rely only on the results of "make check".
(microblaze, cris, nios2, openrisc, tilegx, riscv, xtensa).
If someone has pointers to debian repo for these archs, please share.
Thanks,
Laurent
- Re: [qemu-s390x] [Qemu-devel] [PATCH for 2.13 v2 03/20] linux-user: move arm signal.c parts to arm directory, (continued)
- [qemu-s390x] [PATCH for 2.13 v2 19/20] linux-user: move ppc/ppc64 signal.c parts to ppc directory, Laurent Vivier, 2018/03/23
- [qemu-s390x] [PATCH for 2.13 v2 17/20] linux-user: move sparc/sparc64 signal.c parts to sparc directory, Laurent Vivier, 2018/03/23
- [qemu-s390x] [PATCH for 2.13 v2 20/20] linux-user: define TARGET_ARCH_HAS_SETUP_FRAME, Laurent Vivier, 2018/03/23
- [qemu-s390x] [PATCH for 2.13 v2 16/20] linux-user: move i386/x86_64 signal.c parts to i386 directory, Laurent Vivier, 2018/03/23
- Re: [qemu-s390x] [Qemu-devel] [PATCH for 2.13 v2 00/20] linux-user: move arch specific parts to arch directories, no-reply, 2018/03/23
- Re: [qemu-s390x] [Qemu-devel] [PATCH for 2.13 v2 00/20] linux-user: move arch specific parts to arch directories, Richard Henderson, 2018/03/28
- Re: [qemu-s390x] [Qemu-devel] [PATCH for 2.13 v2 00/20] linux-user: move arch specific parts to arch directories, Alex Bennée, 2018/03/28