Re: [qemu-s390x] [Qemu-devel] [PATCH for 2.13 v2 00/20] linux-user: move arch specific parts to arch directories

[Daniel P . Berrangé]

On Wed, Mar 28, 2018 at 03:41:52PM +0100, Alex Bennée wrote:
> 
> Laurent Vivier <address@hidden> writes:
> 
> > Some files like signal.c are really hard to read
> > because all architectures are mixed in the same
> > file.
> >
> > This series moves from signal.c these parts to
> > the architecture dedicated directories in linux-user.
> > Moreover, this allows to compare easier functions
> > between architectures (it helps to debug problems).
> > Adding new functions for a new architecture will
> > be facilitated too.
> >
> > checkpatch.pl is not happy... but I only want to
> > move code from a file to another. I don't want
> > to change the content of the parts I move.
> 
> I think de-tabifying is worth it as it's a whitespace fix. Sure you can
> leave everything else.

I'm all for doing cleanups of existing code to satisfy checkpatch
too. Just make sure any cleanups are done as completely separate
patches, not fixed with other functional changes.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|