[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH] s390x/virtio: Convert virtio-ccw f
|
From: |
Cornelia Huck |
|
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH] s390x/virtio: Convert virtio-ccw from *_exit to *_unrealize |
|
Date: |
Fri, 9 Mar 2018 11:27:03 +0100 |
On Fri, 9 Mar 2018 10:23:31 +0100
Pierre Morel <address@hidden> wrote:
> On 07/03/2018 17:29, Nia Alarie wrote:
> > Signed-off-by: Nia Alarie <address@hidden>
>
> What you do seems right to me, naming seems more logical, but can you
> please
> add a little commit message explaining why you change the interface?
I had asked Nia to do this; see the comments in qdev-core.h regarding
usage of exit vs. unrealize.
(I have already queued this for a pull request, since I'll be out
starting tomorrow.)
>
> Thanks,
>
> Pierre
>
> > ---
> > hw/s390x/virtio-ccw.c | 34 +++++++++++++++++-----------------
> > hw/s390x/virtio-ccw.h | 2 +-
> > 2 files changed, 18 insertions(+), 18 deletions(-)