[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH] s390x/virtio: Convert virtio-ccw from *_exit to
|
From: |
nee |
|
Subject: |
Re: [qemu-s390x] [PATCH] s390x/virtio: Convert virtio-ccw from *_exit to *_unrealize |
|
Date: |
Thu, 8 Mar 2018 19:24:16 +0000 |
On Thu, Mar 8, 2018 at 4:13 PM, Stefan Hajnoczi <address@hidden> wrote:
> On Wed, Mar 07, 2018 at 04:29:58PM +0000, Nia Alarie wrote:
>> @@ -760,12 +760,12 @@ static int virtio_ccw_exit(VirtioCcwDevice *dev)
>> if (sch) {
>> css_subch_assign(sch->cssid, sch->ssid, sch->schid, sch->devno,
>> NULL);
>> g_free(sch);
>> + ccw_dev->sch = NULL;
>
> This change is unrelated to the topic of the patch and not mentioned in
> the commit description. I think it was probably made for consistency,
> rather than a bug fix or functional change. That's a valid reason too
> but please mention secondary changes like this in future patches so
> reviewers know why you made them.
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
Indeed, this was done for consistency (but also, it feels like a good
practice to follow). Thanks for the review.